joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Fix issue with dependencies, among other selector issues #252

Closed joshwcomeau closed 6 years ago

joshwcomeau commented 6 years ago

Related Issue: closes #251

Summary: Shoot, so yesterday I merged some code that memoized our redux selectors. Kinda late in that PR I changed it so that selectors had a new format: selector(state, props: {arg1, arg2}) (instead of selector(state, arg1, arg2, ...)). This is how reselect wants it to be formatted, since it can easily do a shallow-compare on the props object and use that for memoization (I'm guessing, at least? I didn't dig into this).

Unfortunately, I didn't do a very good job checking that everything still worked. Part of this was after merging master, but some of it was just my own negligence :/ I kinda thought Flow would catch anything I missed, but it's not smart enough to unpack saga select statements.

This PR fixes a number of issues around that, including:

melanieseltzer commented 6 years ago

Would this error be related to this PR? (throws after installing a new project) Looks like it can't find project.dependencies which I feel like is prob related since you said dependencies pane is gone. Didn't want to open a new issue if it's related...

screen shot 2018-09-16 at 8 55 54 pm
superhawk610 commented 6 years ago

@melanieseltzer I can confirm I also get that error on Linux.

joshwcomeau commented 6 years ago

@melanieseltzer yep, that's related. This was a nasty oversight on my part, broke a bunch of stuff D: