Upgrade Electron dependency

joshwcomeau commented 6 years ago

Quick PR to upgrade Electron to 3.0.0.

The big benefit is that we get updated Chromium and Node, including to Node 10, which is exciting. A minor change is a new app.isPackaged property, which I've used in main.js.

I didn't notice any issues upgrading, but it'd be awesome to check this in Windows and Linux.

It's unclear it electron-builder will have any issues, as well. I'll be sure to check it in that branch before merging.

joshwcomeau commented 6 years ago

This is pending the release of 1.3. I don't wanna risk this breaking the electron-builder stuff for now.

AWolf81 commented 5 years ago

I've merged master to this branch and I think we can merge this.

But I'm having two points we should check afterwards or in this PR:

react-scripts not found in production bundle. It's working during development. I think we should open an issue for this as the MacOs issue with Path is still present and this could be related. But it's finding node. Maybe there was a change to finding the project folder. OK, I've found the problem: I imported a project from my reinstall tests and there the node_modules folder of the CRA app was missing. So everything is working - maybe we need to block task run if node_modules folder is not present.

grafik

Check warning message during development & what's causing it. Maybe it's in a dependency we're using. It's inside react-error-overlay but I couldn't see the issue there. The issue is about the usage of new Buffer() similar to this issue.

AWolf81 commented 5 years ago

@joshwcomeau I wanted to merge this but after checking what's the latest electron version. I'm wondering if we should update to electron v4 instead of v3. I'll give it a try and check if there are any issues.

Haroenv commented 5 years ago

The change in yarn.lock (removal of integrity & no change in electron version) don't look correct to me 🤔

AWolf81 commented 5 years ago

@Haroenv The change in the lock file is created with yarn so it should be correct. (It's adding integrity lines) I haven't pushed the update to v4 yet but it seem so work as expected in my working copy.

Haroenv commented 5 years ago

I was confused by the line count being all red on GitHub, while really there were also green counts

joshwcomeau / guppy

Upgrade Electron dependency #260