joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Node available check to inform the user that it's required #270

Closed AWolf81 closed 5 years ago

AWolf81 commented 5 years ago

Related Issue:

263

Summary: Added a check if node -v can be executed with-out a failure. If it fails it will show an error dialog and direct the user to README.md installation section.

It also adds a new property to Mixpanel so we know the used Node.js version & if node is missing. So we know how often it happens that a user starts Guppy with-out installing Node.js first. (Maybe we have to update our privacy.md to have the new information there.)

The local state isNodeMissing is used to disable the Create new project wizard. The create button won't have an effect - we could add a tooltip there & disable the button but I'm not sure if it's worth it to add. As this is a very rare use-case, node not installed and then clicking around in the app.

How to test? I've tested it on Windows by renaming the path to Node binary. e.g. C:\Program Files\nodejs\missing. Then start the Guppy binary to see the dialog from the screenshot below & the redirection.

Screenshots/GIFs: screenshot_node_missing_test

Mixpanel Product dashboard: grafik