search

joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Add Flow check to CI #275

Closed joshwcomeau closed 5 years ago

joshwcomeau commented 5 years ago

We have a pre-commit hook to run Flow whenever a commit is added, but this can be skipped with --no-verify. This can lead to PRs being opened without Flow issues.

We should add a step to CircleCI to run the Flow check as well as the tests.

AWolf81 commented 5 years ago

@joshwcomeau I'll add it.

The execution order doesn't matter, right? I would add it after report-coverage. It should run flow && lint.

Is it OK to change flow check from precommit to prepush as mentioned in your comment?