Flow & lint CI config

[AWolf81]

Related Issue:

275

Summary:

• Added flow & lint check to Circle.CI
• Changed Flow check from precommit to prepush. So commiting is faster and pushing takes some time and for WIP pushs we can use --no-verify.

Note: I think we should check if we're adding node_modules to flow ignore as we're checking over 45000 files. So we can be a lot faster with that ignore.

Todos:

• [x] Fix linting config e.g. to `eslint src/**/*.js config/**/*.js´
• [x] Fix linting warnings:
  • [x] Remove use strict from modules
  • [x] Remove unused createDependency

[mathieudutour]

Changed Flow check from precommit to prepush

I usually prefer to have it as a precommit so you don't commit broken stuff (or do it in perfect knowledge) and keep a cleaner git history. I guess it doesn't really matter in this project since we squash so I don't really mind

[joshwcomeau]

I usually prefer to have it as a precommit so you don't commit broken stuff (or do it in perfect knowledge) and keep a cleaner git history. I guess it doesn't really matter in this project since we squash so I don't really mind

Yeah, this has to do with some funkiness with Flow on Windows, as I understand. As a result, folks tend to just not run the commit hooks with --no-verify.

Thanks for this change! looks great