joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Improve performance of project delete for Windows #277

Closed AWolf81 closed 5 years ago

AWolf81 commented 5 years ago

Describe the bug Guppy freezes during project deletion on Windows. Please have a look at the screen recording and the message Keine Rückmeldung means not responding.

I think this is a problem with the deletion of node_modules folder. I'll have a look at the issue and I think it could be improved by using rimraf for delete process.

To Reproduce

  1. Create Project
  2. Delete project from disk

Expected behavior Delete project with-out freezing.

Screenshots screenrecording_delete_project_freeze

Environment (please complete the following information):

Things to discuss:

joshwcomeau commented 5 years ago

Or as a compromise delete the node_modules folder and move the rest to trash. I think I'll start with this.

That sounds good to me - that way the user can restore a deleted project, and node_modules are easy enough to reinstall (although not really through Guppy... we should add a "reinstall modules" button at some point).

joshwcomeau commented 5 years ago

Fixed in #280