search

joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Improve delete performance #280

Closed AWolf81 closed 5 years ago

AWolf81 commented 5 years ago

Related Issue:

277

Summary:

Performance is better with-out freezing ~26sec now vs. before ~36sec . Deleting a project in terminal with rimraf takes 14sec. Not sure why it's slower in Guppy. File size in trash shrinked from ~120MB to 611kB for a newly created project.

One point we should do separately and we have to discuss is that we're needing a spinner that the delete is in progress as nothing is clickable during deletion (see screenrecording below). Just the application menu is clickable. Maybe changing the mouse pointer to a glass would be the easiest - I don't know why that's not happening at the moment.

Screenshots/GIFs: Improved delete screenrecording_delete_project_improved

joshwcomeau commented 5 years ago

This is great! Really good idea to delete node_modules permanently first. For the UI, what about some sort of transparent overlay over the whole window with a 'Deleting project...' message?

I like that idea! I think a transparent overlay with our spinning fish animation could work (I don't think we need the text "Deleting project..." since it should be clear from context).

It's up to @AWolf81, it doesn't have to be done along with this issue.

joshwcomeau commented 5 years ago

@AWolf81 up to you if you want to tackle the overlay discussed with @melanieseltzer - if you'd rather not, feel free to just merge this as-is :)

We should create a "good first issue" ticket for it, if we don't tackle it right away.

AWolf81 commented 5 years ago

@joshwcomeau I also like the idea with the spinning fish animation overlay but I would create an issue for it - as this is a nice to have feature and a good issue for first time contributors.

I'll merge this improvement as-is.