Closed AWolf81 closed 5 years ago
Merging #289 into master will increase coverage by
0.13%
. The diff coverage is24.24%
.
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 20.09% 20.22% +0.13%
==========================================
Files 235 235
Lines 3648 3653 +5
Branches 368 372 +4
==========================================
+ Hits 733 739 +6
+ Misses 2648 2644 -4
- Partials 267 270 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/main.js | 0% <0%> (ø) |
:arrow_up: |
src/components/Initialization/Initialization.js | 33.33% <44.44%> (+33.33%) |
:arrow_up: |
src/sagas/delete-project.saga.js | 96% <0%> (-0.16%) |
:arrow_down: |
src/reducers/dependencies.reducer.js | 100% <0%> (ø) |
:arrow_up: |
src/reducers/onboarding-status.reducer.js | 37.5% <0%> (+4.16%) |
:arrow_up: |
src/services/shell.service.js | 30% <0%> (+30%) |
:arrow_up: |
Related Issue:
211
Summary:
appWillClose
&triggerClose
Todos
before-quit
handler. Not needed anymore.\n
beween the projects in the dialog message to have a better separation.Things to discuss
CreateProject
build process can be closed with-out dialog. We need to tackle this later as this transition state is not tracked yet.Screenshots/GIFs: