Describe the bug
After merging #292 we will have a new bug that's introduced by Next.js.
Next.js is adding a long-running task called start which is not properly handled by Guppy. We're only expecting one devServer task per project and here we're having two.
Also the task will not check that the port is not already in use.
I think this is no high priority issue as the Next.js devServer is working as expected.
To Reproduce
Create/Open a Next.js project
Run the start task with an open TaskDetailsModal
The message tells Task completed instead of Running
Expected behavior
We need to allow many long running tasks (1 to n tasks) and display this accordingly.
Also adding a isPortAvailable check is needed.
This could be related to #296 as we need to store the isLongRunningTask info somewhere either in state or in a configuration file.
I'm imaging it should be like every task can be toggled from short- to long-running in a tasks setting dialog & also there should be an option to select if a port check is required. Not sure if that's too complicated but that way we can add user customizable tasks for advanced users later.
Todo
[ ] Add a property to devServer config. longRunning: true - I prefer longRunning over sustained as it is more clear.
[ ] Rename devServerTaskNameMap to longRunningTaskNameMap as we can also have non-devserver tasks in the map
[ ] Change longRunningTaskNameMap to use longRunning prop from config
[ ] Update getTaskType in tasks.reducer
[ ] Check isDevServerTask function in tasks.reducer - do we need to change it?
Describe the bug After merging #292 we will have a new bug that's introduced by Next.js. Next.js is adding a long-running task called
startwhich is not properly handled by Guppy. We're only expecting one devServer task per project and here we're having two. Also the task will not check that the port is not already in use.I think this is no high priority issue as the Next.js devServer is working as expected.
To Reproduce
Task completedinstead ofRunningExpected behavior We need to allow many long running tasks (1 to n tasks) and display this accordingly. Also adding a
isPortAvailablecheck is needed. This could be related to #296 as we need to store theisLongRunningTaskinfo somewhere either in state or in a configuration file.I'm imaging it should be like every task can be toggled from short- to long-running in a tasks setting dialog & also there should be an option to select if a port check is required. Not sure if that's too complicated but that way we can add user customizable tasks for advanced users later.
Todo
devServerconfig.longRunning: true- I preferlongRunningoversustainedas it is more clear.devServerTaskNameMaptolongRunningTaskNameMapas we can also have non-devserver tasks in the maplongRunningTaskNameMapto uselongRunningprop from configgetTaskTypeintasks.reducerisDevServerTaskfunction intasks.reducer- do we need to change it?Screenshots
Environment: