remove polyfill since we know we use chromium

joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js

ISC License

3.27k stars 154 forks source link

remove polyfill since we know we use chromium #302

Closed mathieudutour closed 5 years ago

mathieudutour commented 5 years ago

[x] remove Promise polyfill
[x] remove fetch polyfill
[x] remove Object.assign polyfill
[x] only compile down to Chrome 61 (fix #301)

Before:

File sizes after gzip:

  466.51 KB         build/main.js
  181.16 KB         build/electron.js

After:

File sizes after gzip:

  449 KB              build/main.js
  173.15 KB           build/electron.js

j-f1 commented 5 years ago

process.versions.chrome IIRC, @AWolf81.

AWolf81 commented 5 years ago

process.versions.chrome IIRC, @AWolf81.

Thanks @j-f1, good to know that I can look there inside the app. I haven't tested it in Guppy but here is the link to the docs and I'm expecting that it will output chrome 61 for the current Electron version.

mathieudutour commented 5 years ago

I added a check on startup to see if the browser list config matches the electron's version.