joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Quick-fix for initializePath #305

Closed AWolf81 closed 5 years ago

AWolf81 commented 5 years ago

Summary:

Tested with Windows 10 & Ubuntu 16. Renaming the node.js folder on disk is the easiest way to get the node missing dialog.

Please check if this is working on Mac. @mathieudutour I like the idea of using shell:true and echoing the path but I can not test on Mac - that's why I haven't modified this.

For fix-path we can keep it for now and remove it in a release after 0.3.0.

codecov[bot] commented 5 years ago

Codecov Report

Merging #305 into final-node-fix will decrease coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           final-node-fix     #305      +/-   ##
==================================================
- Coverage           20.43%   20.41%   -0.02%     
==================================================
  Files                 239      239              
  Lines                3739     3742       +3     
  Branches              386      387       +1     
==================================================
  Hits                  764      764              
- Misses               2696     2698       +2     
- Partials              279      280       +1
Impacted Files Coverage Δ
src/services/platform.service.js 44.82% <0%> (-5.18%) :arrow_down:
src/components/Initialization/Initialization.js 28.57% <0%> (ø) :arrow_up:
src/services/shell.service.js 30% <0%> (ø) :arrow_up: