Reinstall feature

[AWolf81]

Related Issue:

278

Summary:

• Added application menu item Reinstall dependencies to Current Project.
• Added Reinstall to dependency Saga:
  • Removes Node_modules folder
  • Triggers yarn call
  • Watches stdout from yarn for status updates to LoadingScreen

Things to discuss:

• Do we need a confirmation before executing the reinstall? I think it's not needed as nothing will be destroyed and it's pretty clear what the click will do
• Speech bubble (hidden by default, in the screencast below it only shows because I had it displayed in the previous reinstall): Should we remove it or leave it as is? I just wanted to show a progress but it maybe useful to keep for advanced users.
• For the watching of the stdout we could extract the createStdioChannel function from task.saga but I don't like the API from it. I think we could refactor this afterwards. What do you think?
• Progressbar: It needs to be improved because current fix of 100% display is hacky. Is there a way to get more outputs about the progress from Yarn?

Todos

• [x] Resolve conflict for app-status.reducer
• [x] Fix failing tests
• [x] Check if progress bar can be improved. Improved the progress bar so it can not jump back (like in the screenrecording below).:
  • 100% fix done with a delay (a bit hacky but works)
  • Animating back on next reinstall run fixed with react-spring (ProgressBar component picked from migration branch) & added reset property
  • Jumping backwards fixed by summing the progress instead of using absolute values.

Screenshots/GIFs: Screenrecording of reinstall

Application menu item

Install Dependencies button (if node_modules missing)

[codecov[bot]]

Codecov Report

Merging #318 into master will increase coverage by 0.47%. The diff coverage is 39.69%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   25.35%   25.82%   +0.47%     
==========================================
  Files         152      152              
  Lines        3613     3729     +116     
  Branches      388      397       +9     
==========================================
+ Hits          916      963      +47     
- Misses       2426     2489      +63     
- Partials      271      277       +6

Impacted Files	Coverage Δ
src/constants.js	100% <ø> (ø)	:arrow_up:
src/components/LoadingScreen/LoadingScreen.js	0% <0%> (ø)	:arrow_up:
src/services/read-from-disk.service.js	5.66% <0%> (+0.1%)	:arrow_up:
src/components/ApplicationMenu/ApplicationMenu.js	0% <0%> (ø)	:arrow_up:
src/reducers/projects.reducer.js	57.81% <0%> (-3.86%)	:arrow_down:
src/components/ProjectPage/ProjectPage.js	0% <0%> (ø)	:arrow_up:
src/components/ProgressBar/ProgressBar.js	100% <100%> (ø)	:arrow_up:
src/actions/index.js	94.57% <100%> (+0.55%)	:arrow_up:
src/sagas/task.saga.js	63.84% <50%> (-0.73%)	:arrow_down:
src/sagas/dependency.saga.js	75.43% <52.17%> (-13.14%)	:arrow_down:
... and 3 more

[melanieseltzer]

So, I've been trying to investigate a really weird performance issue in this branch and I'm confused because I can't pinpoint what's causing it. I've checked out each commit one by one to see if it gets introduced somewhere, and it appears and disappears at random.

The top menu will not allow me to click on anything, I roll over something and it just closes the menu. Also there's some weird jumpiness going on with scrolling (page jumps up and down).

This also happens with the reinstall (no errors to console). It flickers and loading screen disappears, but reinstall does eventually work and dependencies reappear. But the flicker is strange.

I'm stumped. I can't tell if it's my machine or widespread, do you encounter any of this on your machine? :/ As far as I can tell it's not on master and just in this branch.

[AWolf81]

I don't have that issue. Have you tried to remove node_modules folder from Guppy and reinstall everything. Really a weird issue. I'll check it on Ubuntu maybe there is a similar behaviour.

Tested with vm MacOs 10.14 & Ubuntu 16.4.03 (I'll setup a Ubuntu 18.x soon to have a more recent version) with-out any issues.

[joshwcomeau]

I tried running this locally and I share @melanieseltzer's issue: "Electron helper" consumes 115% of my CPU after running the reinstall task =(

I also noticed some funkiness with the application menu:

This sometimes happens when an option key is stuck, or something... but that isn't the case now, and the application menu works fine in other applications, so I think somehow there's something about this change causing that :/

[joshwcomeau]

Ah-ha - when I open Guppy and open the Redux Devtools, I see "LOAD_DEPENDENCY_INFO_FROM_DISK" firing over and over. Looks like there's some recursive loop somewhere.

[AWolf81]

@joshwcomeau Thanks for your review. The performance issue should be fixed. Please check if it's fixed. I rewrote the dependency.reducer and added the loading status per project there. Also I'm hiding all tasks if node_modules folder is missing as I think that's easier than disabling every button in the UI. What do you think? Is it OK? I think it's OK as this really an edge case and shouldn't happen often.

There are two points open:

• We probably need a better copy for the info text if node_modules folder is missing. See updated screenshot.
• I'll check if I can add some animations to the speech bubble - if not I think it's also OK to remove it as I think the progress bar is enough info. Do you have an idea how I could fix the display of the progress bar so 100% is visible?

[AWolf81]

@joshwcomeau can you please have a look at this? Is the performance OK now?

I've added everything from your review and removed the speech bubble. There is a new issue for the bubble so we can add this later. I think we can mark that issue as low priority as I think it's not that important to add.

[melanieseltzer]

@joshwcomeau Is this still blocking? Perf issues seem resolved and UI messages are hidden for now until UI is worked on, I think we can merge...