joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Check node version for CRA in Initialization component #322

Open AWolf81 opened 5 years ago

AWolf81 commented 5 years ago

Describe the bug Project creation fails with-out an error message because of an old node version (see screenshot below). I have to update my VM ware node version.

To Reproduce

  1. Check your node version and use a version <8.10.0 (e.g. 8.9.3) (use nvm)
  2. Enable LOGGING in src/config/app.js
  3. Create a new CRA project
  4. Check the console output

Expected behavior

TODOs

Screenshots grafik

Environment (please complete the following information):

joshuaellis commented 5 years ago

Hi @AWolf81

Happy to look into this. Thinking it might be a good place to use the info bar created in #352 to display the error. What do you think?

On app load check that the Node version is matching the required version. If not, display a message and don't render guppy.

I can't seem to see a clear node version that's required to run Guppy, if it can be run on any version then showing the app isn't wrong? What do you think?

AWolf81 commented 5 years ago

@joshuaellis Please have a look into it.

Yes, I think the info bar works here too.

We can render everything and just show the info and disable project creation if the Node version is not correct.