Closed AWolf81 closed 5 years ago
Merging #325 into master will decrease coverage by
<.01%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 20.75% 20.74% -0.01%
==========================================
Files 247 247
Lines 3903 3904 +1
Branches 391 391
==========================================
Hits 810 810
- Misses 2812 2813 +1
Partials 281 281
Impacted Files | Coverage Ξ | |
---|---|---|
src/components/CreateNewProjectWizard/MainPane.js | 0% <0%> (ΓΈ) |
:arrow_up: |
...c/components/CreateNewProjectWizard/SummaryPane.js | 0% <0%> (ΓΈ) |
:arrow_up: |
...rc/components/AppSettingsModal/AppSettingsModal.js | 0% <0%> (ΓΈ) |
:arrow_up: |
...nents/ProjectTypeSelection/ProjectTypeSelection.js | 0% <0%> (ΓΈ) |
:arrow_up: |
Summary: As mentioned by @mathieudutour Next.js was missing in the app-settings modal because we haven't consistently used the
ProjectTypeSelection
component.The PR is adding Next.js to the ProjectTypeSelection component and also uses it in
MainPane
for project creation. Also the missing Summary copy for Next.js is added.Screenshots/GIFs: Summary copy App preferences