joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Semantic colors #326

Closed mathieudutour closed 5 years ago

mathieudutour commented 5 years ago

I took a stab at cleaning up the colors used in the project. There is now:

There is still a bunch of stuff to do:

I updated the colors story to show the semantic colors and the gradients.

melanieseltzer commented 5 years ago

Apologies for the delay here @mathieudutour and thanks for the awesome contribution. We'd love to get this cleaned up and finalized as it's a positive change, would you be interested in continuing work on this?

We were talking on Gitter about primary/secondary/highlight semantic names, and cleaning up the raw colors (like what's listed in your to-list above). We could do this now in this PR, or if you think we should just fix the conflicts so we can merge and just continue with the work afterwards that's fine too, since it seems pretty good to go as is.

Let us know or we'd be happy to take over and deal with getting it finalized if you're no longer interested, no worries at all.

mathieudutour commented 5 years ago

Do take over, it's been a while that I haven't been on this codebase

superhawk610 commented 5 years ago

This has been moved to #377.

melanieseltzer commented 5 years ago

Thanks for your work, @mathieudutour :)