joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

Update eject task UI to failed if git state dirty #333

Closed melanieseltzer closed 5 years ago

melanieseltzer commented 5 years ago

Related Issue:

PR #331 identified the problem.

Summary:

If git state is dirty we need to update the UI to failed, so it's not pending forever.

Is there some way to not have the window refresh afterwards? Would be good if when the UI is updated, the window sits still so user isn't jumped up.

codecov[bot] commented 5 years ago

Codecov Report

Merging #333 into reinstall will decrease coverage by 0.01%. The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##           reinstall     #333      +/-   ##
=============================================
- Coverage      21.44%   21.43%   -0.02%     
=============================================
  Files            246      246              
  Lines           4019     4021       +2     
  Branches         399      399              
=============================================
  Hits             862      862              
- Misses          2871     2873       +2     
  Partials         286      286
Impacted Files Coverage Δ
src/sagas/task.saga.js 63.84% <33.33%> (-1%) :arrow_down:
melanieseltzer commented 5 years ago

Thank you 👍 This is updated.