joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js

ISC License

3.27k stars 154 forks source link

fix: Update screen design #349

Closed joao-alberto closed 5 years ago

joao-alberto commented 5 years ago

Related Issue:

334

Summary: Improve reinstall loading screen status message UI

Screenshots/GIFs: First version demo

Updated version (backdrop + conditional rendering) Screenrecording_LoadingScreen

melanieseltzer commented 5 years ago

Also, the reinstall feature was finalized and merged yesterday so you can rebase master instead of the reinstall branch :)

superhawk610 commented 5 years ago

@joao-alberto just want to touch base and see how things are coming on your end. If you wouldn't mind just dropping a comment to let us know you're still interested in working on completing this PR and getting it merged, that would be much appreciated!

If you don't have the availability to finish it up, that's no problem, we'll open it up for community contributions. I'll update the PR if we still haven't heard back from you in a few days.

AWolf81 commented 5 years ago

@melanieseltzer @superhawk610 OK, I've comandeered this PR. I hope that's OK @joao-alberto. I've addressed the review comments (backdrop & usage during delete). Please let me know what you think.

The conditional rendering based on progress > 0 is the easiest way to use the LoadingScreen for reinstalling Deps & deleting project. I think it's OK to first show with-out progress bar and then display it once there is the first update.

I've also added a filter to the yarn messages so only [1/4] ... text will be displayed. I don't want to have warnings logged at that location.