joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

[WIP] Improve Gatsby starter #353

Closed AWolf81 closed 5 years ago

AWolf81 commented 5 years ago

Related Issue:

47

Summary: After merging #335 I've noticed that entering an url or a starter name wasn't available. The Summary mentioned it but the functionality was removed because of the last UX improvement. Summary is correct again as the features are available once this PR is merged.

Added the following to the input field:

Discussion

superhawk610 commented 5 years ago

I agree with @melanieseltzer, it shouldn't autoselect. If it's going to autoselect, there should be a more clear indication that the highlighted result is selected (something like the text SELECTED next to the result).

+1 for the No description text, I also think it looks better for consistency.

AWolf81 commented 5 years ago

@melanieseltzer I've added a No description text for n/a entries so it looks consistent.

For the selection I've added a text to display that it will be selected. Styling is a bit basic and could probably be improved.

I think it's OK to autoselect as most user will probably just select a starter from the list and won't type it in the input box. They're typing it if they want to use a starter that's not listed in the starter list.