Closed AWolf81 closed 5 years ago
Merging #361 into master will increase coverage by
12.11%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #361 +/- ##
===========================================
+ Coverage 37.54% 49.65% +12.11%
===========================================
Files 158 158
Lines 3540 3351 -189
Branches 449 458 +9
===========================================
+ Hits 1329 1664 +335
+ Misses 1928 1446 -482
+ Partials 283 241 -42
Impacted Files | Coverage Δ | |
---|---|---|
src/components/Sidebar/Sidebar.js | 100% <ø> (ø) |
:arrow_up: |
src/components/CreateNewProjectWizard/BuildPane.js | 97.67% <100%> (+97.67%) |
:arrow_up: |
...s/CreateNewProjectWizard/CreateNewProjectWizard.js | 100% <100%> (+100%) |
:arrow_up: |
...c/components/CreateNewProjectWizard/ProjectPath.js | 100% <100%> (+100%) |
:arrow_up: |
...omponents/CreateNewProjectWizard/ImportExisting.js | 100% <100%> (+100%) |
:arrow_up: |
...c/components/CreateNewProjectWizard/ProjectName.js | 84.9% <100%> (+84.9%) |
:arrow_up: |
.../components/CreateNewProjectWizard/SubmitButton.js | 100% <100%> (+100%) |
:arrow_up: |
src/components/Planet/PlanetGlow.js | 0% <0%> (ø) |
:arrow_up: |
src/components/Debounced/Debounced.js | 0% <0%> (ø) |
:arrow_up: |
src/components/Earth/Earth.js | 0% <0%> (ø) |
:arrow_up: |
... and 29 more |
Related Issue:
309
Summary: This is a larger PR and adds the tests for the following components from
src\components\CreateNewProjectWizard
scramble
method is untested)Todos Write tests for these components
Discussion
updateProject...
method inMainPane.js
? The tests are easy to understand but if there would be a refactor of the component it's some work to rename/modify these tests. Is there a better way of testing prop methods?__tests__
folder here? I think the test files are adding some noise around the components inCreateNewProjectWizard
folder. There are around 10 components and 10 test files. I think it's OK to keep both in the same folder if there are just one or two components. But it's probably also OK to keep all in the same folder. If we'd change to tests folder just imports need to be modified by one additional relative path../
.Notes
Package.json
update ofenzyme
forrenderProp
support (see MainPane.test.js)/* eslint-disable flowtype/require-valid-file-annotation */
is not needed anymore. It was annoying to copy that line to each new test file. Please let me know if it's OK to add the override to.eslintrc.js
file.