search

joshwcomeau / guppy

🐠A friendly application manager and task runner for React.js
ISC License
3.27k stars 154 forks source link

#352 Disable actions that require an internet connection #368

Closed joshuaellis closed 5 years ago

joshuaellis commented 5 years ago

Related Issue: 352

Summary: Implemented a new component called Online Check, put into app.js and hopefully captured all the functions that require an internet connection and disabled them when the device is offline. Also ensured that the NPM information is refreshed when offline from the beginning. There is a visual banner on display also that cannot be hidden.

Screenshots/GIFs: dependency-section new-project-wizard sidebar-button

joshuaellis commented 5 years ago

Thanks for the feedback. I've made those changes do you have any idea why Prettier would have done that? (pretty annoying). Also attached GIFS of the changes in the original post.

AWolf81 commented 5 years ago

The gifs are a bit small and hard to see but no problem. I'll have a look at it in the app.

Yeah, that's pretty annoying. There are still some spaces left in two files. Maybe it's related to your git setting for line endings. You could check if git config --global core.autocrlf is true if you're on Windows. Someone mentioned that this could be also caused by VS code here but I'm not sure. Maybe restarting the editor could help.

joshuaellis commented 5 years ago

Made those amends and hopefully found the last of the whitespace.

Thanks for the direction on VS code. On Mac so I'll dig around more with that issue, imagine I'll get caught down a rabbit hole.

codecov[bot] commented 5 years ago

Codecov Report

Merging #368 into master will decrease coverage by 0.21%. The diff coverage is 23.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #368      +/-   ##
=========================================
- Coverage   37.72%   37.5%   -0.22%     
=========================================
  Files         157     158       +1     
  Lines        3494    3538      +44     
  Branches      440     449       +9     
=========================================
+ Hits         1318    1327       +9     
- Misses       1900    1928      +28     
- Partials      276     283       +7
Impacted Files Coverage Ξ”
src/components/Button/FillButton.js 100% <ΓΈ> (ΓΈ) :arrow_up:
src/components/CreateNewProjectWizard/MainPane.js 0% <ΓΈ> (ΓΈ) :arrow_up:
src/constants.js 100% <ΓΈ> (ΓΈ) :arrow_up:
src/components/Button/ButtonBase.js 100% <ΓΈ> (ΓΈ) :arrow_up:
.../components/CreateNewProjectWizard/SubmitButton.js 0% <ΓΈ> (ΓΈ) :arrow_up:
...s/CreateNewProjectWizard/CreateNewProjectWizard.js 0% <0%> (ΓΈ) :arrow_up:
src/components/OnlineChecker/OnlineChecker.js 0% <0%> (ΓΈ)
...pendencyManagementPane/DependencyManagementPane.js 20.45% <0%> (-1.5%) :arrow_down:
...s/DependencyDetailsTable/DependencyDetailsTable.js 38.46% <0%> (ΓΈ) :arrow_up:
src/components/App/App.js 0% <0%> (ΓΈ) :arrow_up:
... and 9 more