search

joshwcomeau / react-flip-move

Effortless animation between DOM changes (eg. list reordering) using the FLIP technique.
http://joshwcomeau.github.io/react-flip-move/examples
MIT License
4.09k stars 258 forks source link

Remove direct usage of opaque children object #144

Closed AlexanderOtavka closed 7 years ago

AlexanderOtavka commented 7 years ago

Per the react spec, props.children should be treated as an opaque object, not an array. The React.Children api should be used to handle this object.

The current implementation was working fine with regular react, but these changes are necessary for compatibility with substitutes like preact.

AlexanderOtavka commented 7 years ago

Is this ready to be merged?

joshwcomeau commented 7 years ago

Sorry for the delay - I wanted to quickly run the stories myself, and it's been a hectic week.

Thank you for your contribution :) I'm sure Preact/Inferno users will be delighted that it's compatible.

joshwcomeau commented 7 years ago

Published in 2.9.4. I've also sent an invitation to add you as a collaborator on Flip Move :)

The idea is that for those like you who have made high-quality contributions, you should have more control over this project. Feel free to review PRs submitted by others, close solved issues, merge stuff that has at least 1 other approval, etc.

Of course it's up to you if you want to do any of this, but the option is there if it interests you!

AlexanderOtavka commented 7 years ago

Awesome, thanks! I'll do what I can.