search

joshwcomeau / react-flip-move

Effortless animation between DOM changes (eg. list reordering) using the FLIP technique.
http://joshwcomeau.github.io/react-flip-move/examples
MIT License
4.09k stars 258 forks source link

Extract public API typings into libdef #158

Closed Hypnosphi closed 7 years ago

Hypnosphi commented 7 years ago

Should partially fix #157. The react-flip-move_v2.9.x.js file is exactly the same as the one commited in https://github.com/flowtype/flow-typed/pull/844, and they have to stay in sync. Ideally they shouldn't be touched though, unless a minor version comes and brings some new API

joshwcomeau commented 7 years ago

@Hypnosphi I'm guessing we should wait on the PR to flow-typed before launching this?

I'm out of town for the next 4 days (going to React Europe :D), so my responses may be slow. I'll try to pop in periodically because I'd love to get the Flow issues fixed, but apologies in advance if I'm unable.

Hypnosphi commented 7 years ago

People would still have to ignore node_modules/react-flip-move because of src

And there was a change in deps: https://github.com/joshwcomeau/react-flip-move/pull/158/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L71

Hypnosphi commented 7 years ago

we should wait on the PR to flow-typed before launching this?

That totally makes sense. I think I'll add a "Flow support" section to readme then

Hypnosphi commented 7 years ago

https://github.com/flowtype/flow-typed/pull/844 is merged

joshwcomeau commented 7 years ago

Awesome, let's push this out then!

I'm at work but I'm setting a reminder to merge and publish this tonight (in ~8 hours or so)