Closed tobilen closed 7 years ago
Great work @tobilen! I'll take a look at the stories
How do you feel about adding lint-staged
and husky
to run eslint --fix
for staged files automatically on precommit hook?
that'd basically mean modifying source files as a side effect. not sure thats a good idea
Only those that are already modified in the commit (that's the point of lint-staged
)
im not a big fan of git hooks and husky in general. their main purpose is covered by well set up CI systems, and the automation part can be unexpected and unintuitive.
from a more practical standpoint, it apparently breaks a lot of GUI interfaces (https://github.com/typicode/husky/issues/131, https://github.com/typicode/husky/issues/125, https://github.com/okonet/lint-staged/issues/151, https://github.com/ghooks-org/ghooks/issues/40) or requires a lot of configuration (https://github.com/ghooks-org/ghooks/issues/18) as well
Legacy stories work as expected. Please resolve conflicts and update the docs
By the way, you can now create branches directly in joshwcomeau/react-flip-move
, this makes it a bit easier for other contributors to checkout =)
alright, thanks. cant merge myself though, no write access.
Oh, looks like you haven't accepted the invite, please check your email
Woohoo! Awesome work :D
adresses https://github.com/joshwcomeau/react-flip-move/issues/181
yarn eslint:fix
/npm run eslint:fix
)The biggest part is the refactoring of the github issue and legacy stories. I was a bit unsure about refactoring the legacy stories. So maybe take an extra good look at those.