joshwcomeau / react-flip-move

Effortless animation between DOM changes (eg. list reordering) using the FLIP technique.
http://joshwcomeau.github.io/react-flip-move/examples
MIT License
4.09k stars 258 forks source link

Add prettier #182

Closed tobilen closed 7 years ago

tobilen commented 7 years ago

adresses https://github.com/joshwcomeau/react-flip-move/issues/181

The biggest part is the refactoring of the github issue and legacy stories. I was a bit unsure about refactoring the legacy stories. So maybe take an extra good look at those.

Hypnosphi commented 7 years ago

Great work @tobilen! I'll take a look at the stories

Hypnosphi commented 7 years ago

How do you feel about adding lint-staged and husky to run eslint --fix for staged files automatically on precommit hook?

tobilen commented 7 years ago

that'd basically mean modifying source files as a side effect. not sure thats a good idea

Hypnosphi commented 7 years ago

Only those that are already modified in the commit (that's the point of lint-staged)

tobilen commented 7 years ago

im not a big fan of git hooks and husky in general. their main purpose is covered by well set up CI systems, and the automation part can be unexpected and unintuitive.

from a more practical standpoint, it apparently breaks a lot of GUI interfaces (https://github.com/typicode/husky/issues/131, https://github.com/typicode/husky/issues/125, https://github.com/okonet/lint-staged/issues/151, https://github.com/ghooks-org/ghooks/issues/40) or requires a lot of configuration (https://github.com/ghooks-org/ghooks/issues/18) as well

Hypnosphi commented 7 years ago

Legacy stories work as expected. Please resolve conflicts and update the docs

Hypnosphi commented 7 years ago

By the way, you can now create branches directly in joshwcomeau/react-flip-move, this makes it a bit easier for other contributors to checkout =)

tobilen commented 7 years ago

alright, thanks. cant merge myself though, no write access.

Hypnosphi commented 7 years ago

Oh, looks like you haven't accepted the invite, please check your email

joshwcomeau commented 7 years ago

Woohoo! Awesome work :D