search

joshwcomeau / react-flip-move

Effortless animation between DOM changes (eg. list reordering) using the FLIP technique.
http://joshwcomeau.github.io/react-flip-move/examples
MIT License
4.08k stars 259 forks source link

Fix on IE10 #194

Closed nicolasraynaud-millevolts closed 6 years ago

nicolasraynaud-millevolts commented 6 years ago

The props property doesn't seem to be initialized at this point when creating a component, which leads to an error.

joshwcomeau commented 6 years ago

Huh, interesting. Seems odd to be that a variable's instantiation would be browser-specific o_O.

That said, I don't really see any downside to this fix, so if it works... ¯_(ツ)_/¯

I have a couple style nits, but I can just do them as a followup commit. I'll share the commit here, so that if you're interested in contributing again, you'll know a bit more about our conventions.

nicolasraynaud-millevolts commented 6 years ago

Thanks! Right after my PR I've seen that you set lint and styling in the pre-push hook, I'll PR correctly next time ;)

joshwcomeau commented 6 years ago

Yeah, actually I'm surprised the hook didn't take care of the lint issue!

The change was small, just added a comment and fixed the ternary styling.

Thanks again :)