search

joshwcomeau / react-flip-move

Effortless animation between DOM changes (eg. list reordering) using the FLIP technique.
http://joshwcomeau.github.io/react-flip-move/examples
MIT License
4.09k stars 258 forks source link

cdnjs hosting #197

Closed sashberd closed 6 years ago

sashberd commented 6 years ago

Hi We would like to host your library on cdnjs Could you please tell us what file should be hosted? Thanks

joshwcomeau commented 6 years ago

Hey there,

So, I don't have the built files checked into source control (makes for really messy PRs).

They're published via NPM (package name is react-flip-move) with the following paths:

I love cdnjs! Let me know if I can do anything else to help :)

sashberd commented 6 years ago

@joshwcomeau Thanks for your feedback. I saw dist folder on npm from 0.2.0 version. What about older version 0.1.0-0.1.4, what files should be hosted from them? Another issue that I found that versionson git 0.1.5-0.1.7 is not on npm. We will add them manually, but if you could host them also on npm that will great Thanks

joshwcomeau commented 6 years ago

@sashberd ah, do we need to go that far back? We've had dozens of releases since then, and truthfully I was still figuring out OSS releases (this was my first OSS project!). I wouldn't trust the code back then, and I'm not surprised to hear that dist files weren't included (I probably didn't think to include a dist until 0.2.0)

sashberd commented 6 years ago

@joshwcomeau Usually, we have to host all version. However, if the author says that those versions are not relative and not in used at all users for this library, I suppose we could not host them. @PeterDaveHello Can we disregard this versions by author suggest? @joshwcomeau what about second question about version 0.1.5~0.1.7, can you add them to the NPM?

PeterDaveHello commented 6 years ago

I'm fine with that.

sashberd commented 6 years ago

@PeterDaveHello Thanks

joshwcomeau commented 6 years ago

Awesome, thanks!