search

joshwcomeau / react-flip-move

Effortless animation between DOM changes (eg. list reordering) using the FLIP technique.
http://joshwcomeau.github.io/react-flip-move/examples
MIT License
4.09k stars 258 forks source link

Fix typescript typing #220

Closed joshwcomeau closed 6 years ago

joshwcomeau commented 6 years ago

Quick fix for #218

@thupi if you could take a look and make sure I understood, that'd be great. Not a typescript user, so it's pretty important someone correct me if this is wrong :)

joshwcomeau commented 6 years ago

Hmm, buncha tests failing as a result. Need someone with Typescript experience to take a look :)

thupi commented 6 years ago

@joshwcomeau Hi,

I took a quick look at your tests for Typings and discovered that you are importing the component in the test using import * as FlipMove from 'react-flip-move; :-) I think the tests may pass if you correct the test in the same way i mentioned in the #218 :-)

I hasn't been able to test it myself :-) Would yo be able to give it a shot and see if it pass the tests :-) ? Otherwise i might have some time to spent in the weekend :-)

vsaarinen commented 6 years ago

I'll try to open a separate PR soon that should fix this.

joshwcomeau commented 6 years ago

Thanks for the heads-up @thupi! Makes total sense.

And thanks for tackling this, @vsaarinen!