search

joshwcomeau / react-flip-move

Effortless animation between DOM changes (eg. list reordering) using the FLIP technique.
http://joshwcomeau.github.io/react-flip-move/examples
MIT License
4.09k stars 258 forks source link

Add explicit children prop #268

Closed nickjs closed 2 years ago

nickjs commented 2 years ago

Hi!

@types/react has been updated for react 18 to no longer include an implicit children prop on every Component. This means <FlipMove> is no longer usable with the latest react typings because you must pass children to <FlipMove> but TypeScript thinks the <FlipMove> component doesn't accept any children.

This PR adds an explicit children prop to the typings including a doc comment.

Thanks!

nickjs commented 2 years ago

Thanks @xcv58!

JakeThurman commented 2 years ago

@xcv58 Can you create a release for this change? I am running into this issue with the latest version since it doesn't include this change

xcv58 commented 2 years ago

@xcv58 Can you create a release for this change? I am running into this issue with the latest version since it doesn't include this change

Sorry I don't have that permission to do the release, waiting for this https://github.com/joshwcomeau/react-flip-move/issues/233#issuecomment-1107257677

JakeThurman commented 2 years ago

@xcv58 Can you create a release for this change? I am running into this issue with the latest version since it doesn't include this change

Sorry I don't have that permission to do the release, waiting for this https://github.com/joshwcomeau/react-flip-move/issues/233#issuecomment-1107257677

Saw that after posting! Thanks for taking the time to reply.