Update Howler, dev dependencies

joshwcomeau / redux-sounds

Middleware for playing audio / sound effects using Howler.js

MIT License

131 stars 17 forks source link

Update Howler, dev dependencies #4

Closed GeKorm closed 6 years ago

GeKorm commented 7 years ago

Update Howler to BREAKING v2.0.4 (strict version)
Update to webpack v3
Update tests to be compatible with Howler v2, including shims for window.Audio

I've also updated eslint and the airbnb config, however I haven't used --fix; it leads to drastic changes which shouldn't be included in this PR.

Thanks for making this package!

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 0d001b170d17f4ed4bfb021193b0dda584210426 on GeKorm:master into dfbcdc7f65ac52ac5209a1feedfd6af4521aa98b on joshwcomeau:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 93edef25424e1758c112b21fd31e129e0382f06f on GeKorm:master into dfbcdc7f65ac52ac5209a1feedfd6af4521aa98b on joshwcomeau:master.

coveralls commented 7 years ago

Coverage decreased (-10.4%) to 89.552% when pulling 7c26e367c0310e71b3d6dd84c2379d0a596a6dd3 on GeKorm:master into dfbcdc7f65ac52ac5209a1feedfd6af4521aa98b on joshwcomeau:master.

GeKorm commented 7 years ago

Accidentally pushed to the wrong branch, last commit is 93edef25424e1758c112b21fd31e129e0382f06f, coverage is 100%

GeKorm commented 6 years ago

Hi @joshwcomeau, I have another PR to add on top of this one that adds support for all Howler v2 methods. I've been using that in production for about 4 months now. Although we don't use many of the methods, it's been without problems so far.

By the way I'm willing to maintain the repo if you don't have time. Thanks!

joshwcomeau commented 6 years ago

Ah, shoot! Sorry about that; I must've missed the September PR.

Thanks for the offer of maintenance :) yeah, while I hope to be better than letting a PR sit unreviewed for months at a time, I don't use this package at all in my current projects, and don't have the time to give it the attention it deserves. I'll invite you as a collaborator. If you can send me your NPM username (either here or [by email](mailto: joshwcomeau@gmail.com)), I'll give you publish rights as well.

Sorry again for the delay!

joshwcomeau commented 6 years ago

(just making sure I didn't miss an email! Lemme know if I have)

brycemonster commented 6 years ago

Did this get published?

GeKorm commented 6 years ago

@brycemonster Just did, v2 is up