search

joshwcomeau / use-sound

A React Hook for playing sound effects
MIT License
2.76k stars 98 forks source link

fixed @types/howler version #39

Closed nquinlan closed 4 years ago

nquinlan commented 4 years ago

@types/howler had a breaking update between 2.1.X and 2.2, which entirely changed the type definitions. More details here: DefinitelyTyped/DefinitelyTyped#45246.

This update means that it was no longer possible to compile use-sound and running tsdx build resulted in the following error:

semantic error TS2304: Cannot find name 'HowlStatic'.

In order to make the project compile, I've updated the package.json to lock @types/howler on 2.1.2 rather than contending with the breaking change.

I should note that I made my commit with --no-verify since the pre-commit hook gave me a number of errors, which seem unrelated to the change (and which occur even when doing a git commit --allow-empty @ bbb8536.)

joshwcomeau commented 4 years ago

Yikes, thanks for digging into this!

nquinlan commented 4 years ago

Thanks for a great package!