search

joshwlambert / DAISIEmainland

Simulate phylogenetic data on islands with a evolving mainland pool
https://joshwlambert.github.io/DAISIEmainland/
GNU General Public License v3.0
1 stars 1 forks source link

CRAN disallows installing GitHub repos from vignettes #9

Closed richelbilderbeek closed 3 years ago

richelbilderbeek commented 3 years ago

Dear DAISIEmainland maintainer,

Thanks for DAISIEmainland and a vignette that demonstrates part of its workings!

I did spot a CRAN violation in the vignette and I suggest to fix it (which is easy). In the vignette it states:

```{r install dependencies}
remotes::install_github("rsetienne/DAISIE")
remotes::install_github("thijsjanzen/nLTT")
remotes::install_github("joshwlambert/DAISIEmainland")
```

I do enjoy the helpfulness towards the users in this, but it is against CRAN policies to modify the local environment of the user (in this case, the installed packages on his/her harddisk), probably for good reasons.

I suggest to move these lines to the README.md instead.

joshwlambert commented 3 years ago

This has been resolved and will be closed when merged to main

joshwlambert commented 3 years ago

Merged to main.