joshwlewis / base16-unikitty

A warm and bright color scheme for hacking
40 stars 3 forks source link

OSC report reply should use BEL if query uses it #3

Closed blueyed closed 6 years ago

blueyed commented 6 years ago

When querying the text foreground using printf '\e]10;?\a' kitty replies with: ^[]10;rgb:9393/a1a1/a1a1^[\.

However, xterm and urxvt use \a (^G) in the reply: ^[]10;rgb:9393/a1a1/a1a1^G

I.e. they use the delimiter from the query, and not \e\ unconditionally.

Both urxvt and xterm will use \e\ also in the reply when using printf '\e]11;?\e\' (i.e. \e\ instead of \a).

urxvt uses this code to parse the ending delimiter (and uses it in the reply): https://github.com/exg/rxvt-unicode/blob/0767fe71f667f5be4e8967ca6ea27e2b14c19daf/src/command.C#L3214

blueyed commented 6 years ago

Whoops, was meant for the kitty terminal.