search

joshwnj / react-visibility-sensor

Sensor component for React that notifies you when it goes in or out of the window viewport.
MIT License
2.33k stars 195 forks source link

Update to ES6 style React and replaced Browserify with Webpack #123

Closed jphamilton closed 6 years ago

jphamilton commented 6 years ago

Replaced Browserify with Webpack and updated the code base to a more modern JS style (classes for React components, arrow functions, const, let). Updated packages to latest versions (including React 16)

I'm using my fork in a production app and thought I'd pass along the changes.

jphamilton commented 6 years ago

Ok, so this failed because node version is ancient?

joshwnj commented 6 years ago

Thanks @jphamilton there's some good stuff here. I certainly plan to merge this but first need to address some other things, to avoid merge conflicts.

joshwnj commented 6 years ago

Update: I'll be upgrading node version and dependencies first, before doing any rewrites of syntax (#127)

dylmye commented 6 years ago

Any update on this now #127 is in?

joshwnj commented 6 years ago

@jphamilton @dylmye I've fixed conflicts, merged and published to v5.0.1

Thanks again!