search

joshwooding / vite-plugin-react-docgen-typescript

MIT License
8 stars 7 forks source link

Make typescript an optional dependency #8

Closed ndelangen closed 1 year ago

ndelangen commented 1 year ago

if it fails, the plugin does nothing

Hello @joshwooding I decided to sink my teeth into this just to see if I could bite the optional dependency for typescript off.

This is what I came up with. I understand you might not be a fan, It might solve an issue we're facing at Storybook.

See this PR more as an conversation opener.

joshwooding commented 1 year ago

Happy with this PR. Seems like it's the only way to fix the pnp issues

ndelangen commented 1 year ago

Let's do an alpha release and test the change in the wild before committing to the solution?

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 966a35aa723c14f6bf823d16ce86e58b55e61e97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------------------------------ | ----- | | @joshwooding/vite-plugin-react-docgen-typescript | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

joshwooding commented 1 year ago

@ndelangen 0.0.0-20221218231544 is available