joshy / striprtf

Stripping rtf to plain old text
http://striprtf.dev
BSD 3-Clause "New" or "Revised" License
94 stars 27 forks source link

Code review updates #42

Closed plessbd closed 1 year ago

plessbd commented 1 year ago

code review updates

================= test session starts ==================
platform darwin -- Python 3.11.2, pytest-7.3.0, pluggy-1.0.0

collected 30 items

tests/test_ansicpg1250.py .                      [  3%]
tests/test_bytes.py .                            [  6%]
tests/test_calcium_score.py .                    [ 10%]
tests/test_encoding.py .                         [ 13%]
tests/test_french.py .                           [ 16%]
tests/test_from_strings.py ..                    [ 23%]
tests/test_hello.py .                            [ 26%]
tests/test_hyperlinks.py ...                     [ 36%]
tests/test_issue_11.py .                         [ 40%]
tests/test_issue_15.py .                         [ 43%]
tests/test_issue_20.py .                         [ 46%]
tests/test_issue_28.py .                         [ 50%]
tests/test_issue_29.py ..                        [ 56%]
tests/test_issue_37.py .                         [ 60%]
tests/test_issue_38.py ..                        [ 66%]
tests/test_line_breaks_google_docs.py .          [ 70%]
tests/test_line_breaks_textedit_mac.py .         [ 73%]
tests/test_nested_table.py .                     [ 76%]
tests/test_nutridoc.py .                         [ 80%]
tests/test_sample_3.py .                         [ 83%]
tests/test_simple.py ..                          [ 90%]
tests/test_speiseplan.py .                       [ 93%]
tests/test_tx_rtf32.py .                         [ 96%]
tests/test_unicode.py .                          [100%]

================== 30 passed in 0.61s ==================
stevengj commented 1 year ago

I agree that it was urgent to merge this to fix #41.

However, I hope that in a future version you can avoid discarding Unicode characters as I noted above (which will involve updating two of the tests, similar to StripRTF.jl).