Closed GoogleCodeExporter closed 9 years ago
I don't see a patch attached.
Original comment by jonathan...@gmail.com
on 26 Oct 2010 at 3:24
Doh! Trying again
Original comment by bernho...@gmail.com
on 26 Oct 2010 at 3:56
Attachments:
My only question about the patch is why the change to the RENDERING state to
make invisibility changes rather than ACTIVE in AdminToolsComponent? Is it a
timing thing to do with when the componentMO initializes? In any case, you may
only want to do this when the status is increasing. Otherwise, you may run into
trouble for example logging out while invisibile.
One other nitpick: in AdminToolsComponentMO, I'd prefer "setInvisible()" to
"handleInvisibility()" - the similarity with the existing "handleInvisible()"
is confusing.
I've attached an updated patch. If it works for you, go ahead and commit.
Original comment by jonathan...@gmail.com
on 2 Dec 2010 at 5:23
Attachments:
Fixed in rev r1613
Original comment by bernho...@gmail.com
on 15 Dec 2010 at 10:22
Original issue reported on code.google.com by
bernho...@gmail.com
on 26 Oct 2010 at 11:50