josmas / openwonderland

Automatically exported from code.google.com/p/openwonderland
GNU General Public License v2.0
3 stars 5 forks source link

Initially hide avatar #131

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When using MiRTLE, we set up the tutor so that the avatar is invisible. To 
enable automatic login, the avatar should be invisible at login. Attached is a 
patch to admin-tools which reads a property--wonderland.admintools.invisible 
(set in the darkstar property sheet of the server admin). If the value of the 
property is true, all users that login as part of the admin group are initially 
invisible.

Original issue reported on code.google.com by bernho...@gmail.com on 26 Oct 2010 at 11:50

GoogleCodeExporter commented 9 years ago
I don't see a patch attached.

Original comment by jonathan...@gmail.com on 26 Oct 2010 at 3:24

GoogleCodeExporter commented 9 years ago
Doh! Trying again

Original comment by bernho...@gmail.com on 26 Oct 2010 at 3:56

Attachments:

GoogleCodeExporter commented 9 years ago
My only question about the patch is why the change to the RENDERING state to 
make invisibility changes rather than ACTIVE in AdminToolsComponent? Is it a 
timing thing to do with when the componentMO initializes? In any case, you may 
only want to do this when the status is increasing. Otherwise, you may run into 
trouble for example logging out while invisibile.

One other nitpick: in AdminToolsComponentMO, I'd prefer "setInvisible()" to 
"handleInvisibility()" - the similarity with the existing "handleInvisible()" 
is confusing.

I've attached an updated patch. If it works for you, go ahead and commit.

Original comment by jonathan...@gmail.com on 2 Dec 2010 at 5:23

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in rev r1613

Original comment by bernho...@gmail.com on 15 Dec 2010 at 10:22