josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

Pull request for drone-ecs plugin #1

Closed furybyname closed 8 years ago

furybyname commented 8 years ago

I've updated the namespaces to use plugins/drone-ecs.

.drone.sec will have to be updated

environment:
  - DOCKER_USER=someuser
  - DOCKER_PASSWORD=somepassword
  - DOCKER_EMAIL=email@email.com
tboerger commented 8 years ago

Generally pretty well, now i will do my initial nitpiking ;).

You should execute go fmt ./... in the project root directory.

tboerger commented 8 years ago

You should move the documentation like aws-codedeploy to DOCS.md

tboerger commented 8 years ago

Maybe you should add a logo.scg like https://github.com/gilbarbara/logos/blob/master/logos/aws-ec2.svg or https://github.com/gilbarbara/logos/blob/master/logos/aws.svg

furybyname commented 8 years ago

Changes made. I think I've updated all the var names to be closer to AWS SDK.

tboerger commented 8 years ago

Now I'm fine with it. LGTM

tboerger commented 8 years ago

@furybyname are you able to test drone-aws-codedeploy? :)

furybyname commented 8 years ago

@tboerger cool! I'll have a go at testing drone-aws-codedeploy

furybyname commented 8 years ago

Main issue I've run into https://github.com/drone-plugins/drone-aws-codedeploy/issues/4