Closed furybyname closed 8 years ago
Generally pretty well, now i will do my initial nitpiking ;).
You should execute go fmt ./... in the project root directory.
You should move the documentation like aws-codedeploy to DOCS.md
Maybe you should add a logo.scg like https://github.com/gilbarbara/logos/blob/master/logos/aws-ec2.svg or https://github.com/gilbarbara/logos/blob/master/logos/aws.svg
Changes made. I think I've updated all the var names to be closer to AWS SDK.
Now I'm fine with it. LGTM
@furybyname are you able to test drone-aws-codedeploy? :)
@tboerger cool! I'll have a go at testing drone-aws-codedeploy
Main issue I've run into https://github.com/drone-plugins/drone-aws-codedeploy/issues/4
I've updated the namespaces to use plugins/drone-ecs.
.drone.sec will have to be updated