josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

Container name is not configurable but defined by convention #10

Closed lucamaraschi closed 7 years ago

lucamaraschi commented 7 years ago

If we check line https://github.com/drone-plugins/drone-ecs/blob/master/main.go#L115 the container name in the Task Definition is not configurable but conventionally set to {family-name}+'container'. This is not documented and we should make it configurable as it might conflict with initial configurations especially when the service is behind an Application Load Balancer.

josmo commented 7 years ago

Fixed in .5 and up.