search

josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

Added Container Name setting #11

Closed lucamaraschi closed 7 years ago

lucamaraschi commented 7 years ago

This should fix #10

tboerger commented 7 years ago

Thanks for that, but to get it included into the 0.4 version you have to point the PR against the release/0.4 branch.

lucamaraschi commented 7 years ago

Thanks @tboerger I am going to proceed with the fixes and update the PR

josmo commented 7 years ago

@lucamaraschi, I just took over this repo. I'm not planning on publishing .4 images but I did include this fix in the .5 version of the plugin. Have you moved to .5 yet? I don't use ECS often so I'm going to depend on others to make sure it works in their scenarios :)

lucamaraschi commented 7 years ago

@josmo Let me check ;-)

lucamaraschi commented 7 years ago

LGTM

josmo commented 7 years ago

Thanks, I'll close this pr out