josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

Optional AWS credentials #12

Closed AKoetsier closed 7 years ago

AKoetsier commented 7 years ago

This PR uses the aws go-sdk default aws credentials chain to allow the plugin to use iam instance-roles.

tboerger commented 7 years ago

LGTM

josmo commented 7 years ago

@AKoetsier I've include this in the .5 version of the plugin. I'm not going to be publishing .4 version. Are you still on .4 or you good with me closing this out?

AKoetsier commented 7 years ago

We are still on .4 but we already are using a fork to use this plugin so it doesn't really matter that much.

josmo commented 7 years ago

Closing out since it no longer seems needed