search

josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

Update to use govendor and logConfiguration #18

Closed josmo closed 6 years ago

josmo commented 6 years ago

I think this should address https://github.com/josmo/drone-ecs/issues/17 I grabbed part of it from 0.4 https://github.com/josmo/drone-ecs/pull/9 and abandoned https://github.com/josmo/drone-ecs/pull/16

josmo commented 6 years ago

@joshdvir I'm not sure if this was one of the things you wanted on it. If what you're working on ends up working better, I'm willing to merge\retire the repo too :) probably doesn't need to have multiples

joshdvir commented 6 years ago

@josmo this is what I wanted, thanks for merging it. Don't think there is a need to retire, there is a major difference between the two, yours is able to creat a new task definition and update memory/all other options as opposed to mine that takes the current task definition and only updates the image to a new version so basically you can't change things. Of course, everyone prefers other things, I think both should stay.