search

josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

Add healthcheck fix stringflag #30

Closed ibolmo closed 5 years ago

ibolmo commented 5 years ago

Unintentionally used StringFlag instead of StringSliceFlag for health check command.

ibolmo commented 5 years ago

I'm currently testing this with our build. I'll report back success in a bit.

josmo commented 5 years ago

Sounds good, let me know how it works and I'll merge

ibolmo commented 5 years ago

@josmo ok we're good. Sorry for the delay. Turns out that the ALB was the health-check culprit. At this point, though, we're covered if and when AWS decides to use the task/container definition to map to the ALB health check.

josmo commented 5 years ago

@ibolmo no worries. Glad that it'll be working now :) Let me if the latest image works for you once it's published and I'll publish out a tag. Doesn't look like there would be any breaking changes