josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

ValueFrom field in environment variables #46

Open briancurt opened 5 years ago

briancurt commented 5 years ago

It would be great (and fairly straightforward, I'd believe?) if we could create the container definition with environment variables that support the valueFrom field.

Something like:

environment_variables_from:
  - DB_PASSWORD=<ssm_parameter_store_key_arn>

From the AWS console:

image

I personally use AWS SSM Parameter Store for some settings and would prefer to keep using it rather than relying on Drone's internal secret store for the application secrets.

What do you think?

jtallinger commented 4 years ago

Hi,

I think this is now covered by this change: https://github.com/josmo/drone-ecs/pull/56