search

josmo / drone-ecs

Drone plugin for triggering Amazon EC2 Container Service (ECS) deployments
Apache License 2.0
30 stars 41 forks source link

status code: 400 returned does not cause build to fail #5

Closed fridaystreet closed 8 years ago

fridaystreet commented 8 years ago

The following error isn't causeing the build job to fail, it's still completes with a status of successful.

Drone AWS ECS Plugin built at 2016-01-26 08:59:19 UTC ServiceNotFoundException: Service not found. status code: 400, request id: 8eacbfc6-cd58-11e5-8bb2-4558b2059ecf

As per bradrydzewski comment in gitter

bradrydzewski 09:01 it looks like this error is being triggered https://github.com/drone-plugins/drone-ecs/blob/master/main.go#L178 which does not result in an exit 1 but probably should

Cheers Paul

bradrydzewski commented 8 years ago

this was a quick fix. added exit code 1 when this error is received. see https://github.com/drone-plugins/drone-ecs/commit/395f6872c0347508f8be5a99aa7c7ae2afb894cd

fridaystreet commented 8 years ago

haha awesome thanks :-)