josmo / drone-k8s-deployment

Golang drone plugin to update k8s deployments
2 stars 2 forks source link

Allow container_names to be optional #5

Open shnhrrsn opened 5 years ago

shnhrrsn commented 5 years ago

It would be great if the container_names property was optional and just defaulted to the value of deployment_names.

I’m using this plugin with Rancher 2 where workloads and containers have identical names by default, so if I'm updating multiple workloads I'd need to duplicate the exact same values in both container_names and deployment_names which gives me syncing nightmares if someone only updates one for a new workload :)