search

josmo / drone-rancher

Drone plugin for triggering Rancher deployments
53 stars 35 forks source link

Paginate services #21

Closed steve-gray closed 7 years ago

steve-gray commented 7 years ago

@josmo

If a service is not in the first page, this plugin was not checking .Next() and paginating - Rancher defaults to 100 items returned, maxing out at 1000.

In future I'll submit a seperate PR relating to pagination over environments (much less of a problem).

steve-gray commented 7 years ago

@josmo - Is there any chance of getting this released this week? If there's any questions or problems, let me know and I'll fix ASAP.

josmo commented 7 years ago

Thanks @steve-gray, I'll take a look in a couple hours and will merge asap

josmo commented 7 years ago

@steve-gray it should be published, let me know if you run into any issues.

josmo commented 7 years ago

@steve-gray actually looks like it breaks the plugin. I'm going to try to fix but may have to back this out. Looks like the break, breaks out of one loop but not the other and gets stuck infinitely.

josmo commented 7 years ago

ok I fixed the breaking out of the parent loop. when I get a change I'll look at making a it a bit more clear on what it's doing.

steve-gray commented 7 years ago

Cheers: I'm not 100% happy with it either - A likely better fix is to use the filters to search for exact service names - but I'll be damned if I can find any docs on the API syntax for what it's expecting for passing the service names. I was going to break out wireshark and see how the UI handles this.....

A far less urgent problem is reaching 100 environments which will have the same problem.

Sent from my iPhone

On 9 Jun 2017, at 06:21, Joachim Hill-Grannec notifications@github.com wrote:

ok I fixed the breaking out of the parent loop. when I get a change I'll look at making a it a bit more clear on what it's doing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

josmo commented 7 years ago

Yeah 100 environments is probably a little less used ;) I don't know if you know this but you can hit {rancherhost}/v2-beta/stacks and it will give you a good idea of what filters are available and what not :) When I get a change I'll dig more but if you were going down that path I thought it might help