search

jossmac / react-images

🌄 A mobile-friendly, highly customizable, carousel component for displaying media in ReactJS
http://jossmac.github.io/react-images
MIT License
2.34k stars 440 forks source link

How to enable pinch to zoom? #342

Open mhedengren opened 4 years ago

mhedengren commented 4 years ago

I really like this package and if there somehow was a way to pinch to zoom on mobile devices it would be perfect.

I saw an issue on this from 2017 and I was wondering if anyone ever came up with a solution? Or if there are any workarounds for how to make it work.

davwheat commented 4 years ago

As far as I'm aware there isn't any set way to do this yet.

When I can, I'll look into how this can be done.

mhedengren commented 4 years ago

As far as I'm aware there isn't any set way to do this yet.

When I can, I'll look into how this can be done.

That would be greatly appreciated!

patelrr commented 4 years ago

Hey, I have integrated React images (existing) with hammerjs. Will create a demo integrating both and post link here. Sorry, bit busy these days. Will try to get it ASAP.

patelrr commented 4 years ago

Sample code - https://codesandbox.io/s/dazzling-goldberg-0u22t

Sample Output - https://0u22t.csb.app/

Plz ignore code style, didn't got time to follow coding style.

davwheat commented 4 years ago

Thanks for the example @patelrr.

If you'd like, you can submit a PR to add this functionality to the component, or I can add it when I have time.

patelrr commented 4 years ago

@davwheat would love to submit PR. But a bit busy these days. I will need some time to do so.

jackson-dikey commented 4 years ago

Thanks for the example @patelrr.

If you'd like, you can submit a PR to add this functionality to the component, or I can add it when I have time.

If this functionality is implemented, it will be very cool!

anhtran commented 4 years ago

That's cool to use this feature.