search

jossmac / react-scrolllock

🔒 Prevent scroll on the <body />
https://jossmac.github.io/react-scrolllock
MIT License
450 stars 40 forks source link

Components are re-mounted when isActive changes #38

Open eirikurn opened 5 years ago

eirikurn commented 5 years ago

Since they move between being direct descendants of ScrollLock, and children of SheetLock:

https://github.com/jossmac/react-scrolllock/blob/master/src/ScrollLock.js#L52

This is bad for performance and breaks state and transitions.

joebentaylor commented 5 years ago

I agree, this is a huge issue and makes everything look broken.