ThomasThelen commented 6 years ago

12 Fixed

11 Fixed

3 Fixed

4 Partially Fixed (needs you)

1 Fixed

Don't bother looking at the individual commits, it took ~ 3 hours of trial and error to get Travis CI working :/

I added some unit tests for the maze class and refactored a little of maze_viz.

Feel free to rename the example programs to something more descriptive.

To Complete Issue 4

You need to go to https://travis-ci.org and sign in with your github account and add MazeGenerator to the repo list. I should have set everything else up such that it works out of the box (I got it on build 23 :/). Right now we have three unit test failures, but I'll put that into a different issue. In case you didn't know, Travis will run our unit tests every time we commit to master.

We also test this on Python 3.6, Python 3.5, and Python 3.4. To test any more versions that you are interested in, add them in the travis.yaml file. It's great that this all gets automated, and lets us know when anything breaks.

To get Code Climate up and running, head over to https://codeclimate.com and sign in with github. Add the MazeGenerator repo.

In the badges in the readme, I put your name in so that you shouldn't need to copy the markdown over from the sites.

jostbr commented 6 years ago

This looks great. Could I change the name of the repository without messing up anything you've done in the pull request? If yes; do you have any suggestions. I feel like MazeGenerator isn't the best fit for the repo anymore as most of the code now involves solving and animating them. I would like to go in a direction of something like maze-lib, maze-viz, maze-fun. Thoughts?

ThomasThelen commented 6 years ago

That sounds fantastic. What about something like pymaze - A maze generator, solver, and visualizer for python? It would be great to make it an official package with PyPi

I have a couple more fixes in my working branch that I'm not quite ready to commit-but being a C++ guy I think you'll enjoy it!