search

josteink / device_asus_tf101

cyanogenmod compatible device tree for asus tf101
12 stars 6 forks source link

Keyboard toggle for trackpad does not work. #11

Closed josteink closed 11 years ago

josteink commented 11 years ago

Investigate TF300T & TF700T codebase to see if we got freebies we can port from here.

whirleyes commented 11 years ago

In file asusdec/jni/com_cyanogenmod_asusdec_KeyHandler.cpp change #define ASUSDEC_DEV "/dev/asusdec" to #define ASUSDEC_DEV "/dev/asusec"

dlumberg commented 11 years ago

have you tried this? the tf700 code changed to asusdec in most places and the java lib is now asusdec.

josteink commented 11 years ago

Building and testing it now.

josteink commented 11 years ago

Besides dev asusec exists unlike asusdec ;)

That's certainly embarrassing.

dlumberg commented 11 years ago

Makes sense, I figured that the mount point would have been changed with the rest of the code. Where is that getting set?

josteink commented 11 years ago 
$ grep -R "asusec" * | wc -l
88

Evidently all over the place :)

Seriously though, I don't see where it's getting set, but I'm trying the build now with that slight modification and it seems to do have an effect. It makes the entire dock unusable after pressing the touchpad toggle. Undocking and redocking is no good :)

I guess a little bit more work is needed, but in all fairness, it does disable the touchpad as well. Lol.

dlumberg commented 11 years ago

lol, almost all defines for keyboard languages.

The /dev mountpoint is here: ramdisk/ueventd.ventana.rc:/dev/asusec 0660 system system

I'm thinking that I'll go through later and update all of the references to asusdec, including the one for the keyhandler, just for consistency.

josteink commented 11 years ago

Retesting now, it actually does work.

If you want to clean up the references later, that's all cool too, but right now I'll do a push and consider this fixed.

dlumberg commented 11 years ago

Sounds good to me.

josteink commented 11 years ago

Fixed in https://github.com/josteink/device_asus_tf101/commit/b32704bc364bc1928b4960346822a93b30415baa

dlumberg commented 11 years ago

I decided not to update the code to asusdec because I found that the kernel relies on asusec and the asusec mount point.

josteink commented 11 years ago

Then we'll leave it at that and I honestly don't see a problem with it.