search

josteink / device_asus_tf101

cyanogenmod compatible device tree for asus tf101
12 stars 6 forks source link

Possible to add "phablet" toggle? #14

Closed josteink closed 11 years ago

josteink commented 11 years ago

Basically a toggle for left aligning nav bar controls.

Supposed to already be in team eos.

Workaround: Use auto-patcher as suggested by dlumberg

josteink commented 11 years ago

Sneakpeak in Team EOS code:

https://review.teameos.org/#/c/1479/ https://review.teameos.org/#/c/1479/1/overlay/frameworks/base/core/res/res/values/config.xml

Probably has other dependencies, but it's a start.

Investigate/grep following git-tree for hybridUI: http://git.teameos.org/eos/device/asus/tf101.git/log/?h=jellybean-4.2

From shell session:

# eos
jostein@OFFICE:~/unbuild/eos/tf101$ grep -iR "HybridUi" *
overlay/frameworks/base/core/res/res/values/config.xml:    <bool name="config_isHybridUiDevice">true</bool>
# CM10.1
jostein@OFFICE:~/unbuild/eos/tf101$ grep -iR "HybridUi" /mnt/build/android/tf101/4.2/frameworks/base/core/res/res/values/config.xml
jostein@OFFICE:~/unbuild/eos/tf101$

Not very surprisingly, not present at all in CM10.1.

Will a fork of CM10.1 frameworks/base be needed to implement this? Because if so, this feature is pretty much at the bottom of the list.

josteink commented 11 years ago

There's other mod's for this out there, but for other devices. Example: http://forum.xda-developers.com/showthread.php?t=2154075

Investigating what mod consists of.

PMed poster of said mod. Following into that rabbithole lead to Auto-patcher: http://forum.xda-developers.com/showthread.php?p=27589651

Auto-patcher has a tabletUI mod based on "findings" from this: http://forum.xda-developers.com/showthread.php?t=1876842

Zip can no longer be DLed from this thread (Dropbox, 404), but it refers to another thread for "technical" details: http://forum.xda-developers.com/showthread.php?t=1780970

Seems to be based on CM10 though.

This post is specifically about patches for 4.2 though: http://forum.xda-developers.com/showpost.php?p=34752461&postcount=879

Attached ZIP contains changes to system/framework's android.policy.jar and services.jar. Seems like it can be handled in the overlay somehow.

josteink commented 11 years ago

Interesting commit to work from: https://github.com/mateor/cm_frameworks_base/commit/c092c61d5a222a994c4c82a18dd136701c0ea9b7

LoveJunky commented 11 years ago

EOS code is in their settings app

https://review.teameos.org/#/c/1470/ https://review.teameos.org/#/c/1471/

josteink commented 11 years ago

As far as I can tell, those commits are only about the settings/preferences part, the UI of those and whatever storage things should be persisted to. They don't seem to cover actual changes to how Android renders it's UI. Or am I missing something obvious?

That aside: Something like this would ofcourse be nice to add on top of a change in the rendering-engine itself.

Edit: I see one those commits are labeled "Bring in tablet style feature (1 of 2)". It would be interesting to see what is in part 2. That might be just what we're looking for :)

dlumberg commented 11 years ago

Auto Patcher has tabletUI support for cm10.1

http://forum.xda-developers.com/showthread.php?t=1719408

josteink commented 11 years ago

I'd test it myself, but I'm packing for my vacation and don't have time to ruin my tablet and fix it up again :)

josteink commented 11 years ago

That said: good catch!

josteink commented 11 years ago

I'm saying we're good with auto-patcher at this point. Closing.